ORNL / ORNL/cpp-proposals-pub

LWG-small-group-05-24

Open
#247 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
29
Forks
26
PR merge metrics
No merged PRs in 30d

Description

mdspan.overview
  • reword make grammar correct [9aded85f022]
  • drop domain codomain [9aded85f022]
  • remove = pointer() [5cf840533a203]
  • define default constructor, make requires a constraint [5cf840533a203]
  • fix semiregular etc: LEWG explicitly didn't want this [3974b8eec73180] [1bd8e5306dc49c4c8]
  • check that the deduction guide is needed for ElementType* extents<> as arguments [bfacbc3563732]
  • par 5: define this as A specializtion of mdspan is ... if its member thingies are [53100796c33a0f]
  • Move par 6 rewritten before 4 as Mandates and Preconditions [5945ff4f4a760]
    • par 6: If ElementType is ... [5945ff4f4a760]
    • Mandates: fro ElementType, Extents, is_same_v<...> [5945ff4f4a760]
    • Preconditions: LayoutPolicy, AccessorPolicy without shall [5945ff4f4a760]
  • Need member, non-member std::swap for mdspan
mdspan.ctor
  • 1.2 index_sequence<size_type,N> [obsolete]
  • 3.3 Value initializes acc_. in all the constructors [5cf840533a203]
  • 4.2 instead of extents_type is constructible, we check rank and dynamic_rank etc. same for 1.2 [f48d190899ee]
  • Reverse order of constraints and mandates, constraints come first [4e9feb696d89]
  • 17.2 fix the wording and comma and another s for accessible [4e9feb696d89]
  • 19 fix the OtherLayoutPolicy::mapping_type [4e9feb696d89]
  • 20. constraints make that requires in synopsis [bfacbc3563732]
mdspan.members
  • remove 3.1 [960a8c0517c]

  • 4: remove trailing dot [960a8c0517c]

  • 6. as const to make span/array do the right thing [960a8c0517c]

  • static_cast<size_type>(as_const(indicies[P]))... [960a8c0517c]

  • mdspan.accessor.general/2 policies should be policy's [960a8c0517c]

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the mdspan.overview section and review the surrounding wording and existing checklist changes. Add the missing member and non-member std::swap specification for mdspan, then confirm the overview checklist item is complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.