LWG 2022-04-01
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 29
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Description
-
make layout_stride::rank expo only[6d977427dee3] -
strides return span<const size_type,rank> no const &[a826c4372da4ef21] -
take span by value, and take it as span<SizeType, rank>[a826c4372da4ef21] -
layout reqmts: than instead of then in 8[c696dff6eb13b] -
layout policies: trivial type not trivially copyable[c696dff6eb13b] -
ubsections don't repeat the class name in the sub sub section[f32e2f44252b5]- Also made the stable tags mdspan.layout_left.XXX instead of mdspan.layout.left.XXX matching the subsection depth
-
left most -> leftmost[c696dff6eb13b] -
has stride 1, and (add comma)[c696dff6eb13b] -
remove the const on static is_unique etc.[f1f054714c8bd092e]
layout right mapping remove the layout_right requirements wording [c696dff6eb13]
think about r+1 rev-prod-of-extents()[52e266f28457533]- fixed: there was a mismatch of the range, now we do this by excluding r in the range of extents we multiple, hence you can pass in r+1.
par 2.3: extra l in constructlible[a9385afda62ecc]par 4: let P be a parameter pack (instead of the parameter pack)[a9385afda62ecc]
layout_stride: remove the trivial etc. [c696dff6eb13b]
expo:
1.2 if the size of the multi[d313069305d62]1.3 static_cast<decltype(e.extent(r))> (strides[r])[d313069305d62]2: no comma before "that"[d313069305d62]
layout.stride.ctor
Let b a permutation of the integers in the range [0, rank) [0c2ca821e3a71615]
3.1 i in math font, say rank_index of e [2ab5db0a9c276f1]
3.3 greater than 0 (not zero) [71caa55924]
4. as_const(s[d]), use d as math font [2ab5db0a9c276f1]
- also checked all other integers used in conjunction with "in the range"
5.1 add missing typename [46436acfa4e0f0]
6.4 / 5.5: make them mandates
7: replace with effects: issue with better candidate of user defined comparison [46436acfa4e0f0]
8: The expression inside explicit is equivalent to: [46436acfa4e0f0]
layout_stride.obs
4. index_sequence_for<Indicies...>, [a9385afda62ecc]
6.1 true if rank is 0 (digit) [71caa55924]
6.2 move 5 into 6.2 [0c2ca821e3a71615]
- also did this in the equivalent phrase in the constructor of layout_stride
- is well formed and evaluates to true
9. True, if()[46436acfa4e0f0]
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the remaining unchecked entries, “6.4 / 5.5: make them mandates” and “7. is well formed and evaluates to true,” in the LWG 2022-04-01 checklist. Locate the associated proposal text from the repository context, determine the intended wording or requirements change, and mark the entries complete once the edits are made.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100