ORNL / ORNL/cpp-proposals-pub

P0009 LWG Review 22-03-11

Open
#209 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
29
Forks
26
PR merge metrics
No merged PRs in 30d

Description

In terms
  • rename I_b and I_e into L_i, U_i
  • The size of a multidimensional index for each dimension i
Exposition only functions:
  • 22.7.x.2 Exposition-only (have a -)
mdspan.layout.reqmts
  • strike E and e from mdspan.layout, replace with M::extent_type and m.extents()

  • 1.5: add Note: The type of each element of i and j can be a different integer type.

  • Stop sentence, after Cpp17EqualityComparable, then: Furthermore, 3d64c6a443608

    • I made a bullet list, otherwise it wasn't clear that all the conditions are necessary for meeting the requirements for layout mapping.
  • par 2: Result: A type which is a specialization of extents.

  • par 4: for which .... denotes the type M. e72e9555324

  • par 6: strike the returns statement e72e9555324

  • After 7: Returns: A value less then numeric_limits::max<M::size_type> e72e9555324

  • par 8:

    • make postcondition in its own thing: result: bool , value: true e72e9555324
    • spaces around == e72e9555324
  • par 10: If the multidimensional index space e has size 0 ..., for all i. (remove ...) e72e9555324

  • par 12: name change: is_exhaustive, LEWG -> name change /

  • par 16: replace "e", r math font: add clarifying note maybe example e72e9555324

  • par 17/20/23: Result: A constant expression ([expr.const]) of type bool. e72e9555324

  • strike par 19, 22, 25 e72e9555324

  • par: 18/21/24: true only if, drop Otherwise, Add note: to the effect that it may return false even if all m are 3f9b67c737c6d

    • also added note to the non-static functions!
  • m.is_stride move under is_strided e72e9555324

  • Add new subheading for layout policy reqmts 3f9b67c737c6d

  • 30: replace is_same_v with denotes 3f9b67c737c6d

22.7.3.1
  • The size of the multidimensional index space e is 3f9b67c737c6d
    • Added sentence that representations of multidimensional index spaces will be used synonymously

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the mdspan.layout.reqmts material and section 22.7.3.1 in the repository, then review the listed wording changes and referenced commits 3d64c6a443608, e72e9555324, and 3f9b67c737c6d. Done means the requested terminology, requirements, notes, headings, and paragraph edits are consistently reflected in the proposal text.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
documentation
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.