P0009 LWG Review Notes 2022-02-18
Open
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 29
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Description
Terms:
para 2: connect the "rank" to a particular multidimensional index space.(was already done in R15)paragraph 3: "multidimensional" index space make r in math font, drop (or representation thereof)(done in f9d2e0aef989 )paragraph 3: space in [0,rank)(done in f9d2e0aef989)
mdspan.extents.overview:
delete copy constructor and assignment operator(done in ea8252187f37)add: using rank_type = size_t;(done in ea8252187f37)convert fold expression to rank_type static_cast<rank_type>(Extents==dynamic_extent)(done in ea8252187f37)
paragraph 3: Extents in code font(done in f9d2e0aef989 )paragraph 6: The rth interval of a multidimensiona index space represented by an extents object is [..)(done in f9d2e0aef989 )move static stuff up front in synopsis so we can use them in constructor explicit clauses(done in f9d2e0aef989)- Note also moved non-static
extent(i)up in order to keep it next tostatic_extent - did not move the full description of the functions before constructors - should we?
- Note also moved non-static
paragraph 2: is a trivially copyable type that models regular(done in f9d2e0aef989).
later stuff
remove move ctors/assign for mapping(was already done in R15)remove unnecessary std:: prefix(done in 39d9e5f459f77)layout_stride::mapping remove unnecessary typename(done in fd9ddb95a3684d)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the review checklist in the issue, including the mdspan.extents.overview and later-stuff sections, and verify the referenced revisions. Nearly every item is marked done or already addressed; the only stated open question concerns moving full function descriptions before constructors, so confirm whether that discussion still needs a decision.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 15/100