ORNL / ORNL/cpp-proposals-pub

Code in the wording of needs to follow the ISO formatting conventions

Open
#16 3 comments 0 reactions 1 assignee View on GitHub

@dsunder is already working on this.

Since May 6, 2018.

subject - atomic_ref (P0019) subject - mdspan (P0009) work - wording
Dominant language
HTML
Stars
29
Forks
26
PR merge metrics
No merged PRs in 30d

Description

The code formatting is very inconsistent right now. It all should follow the ISO coding guidelines.

For example:

   template< ptrdiff_t ... LHS , ptrdiff_t ... RHS >
   constexpr bool operator == ( extents<LHS...> const & lhs , extents<RHS...> const & rhs ) ;
  • ISO doesn't put spaces in between operators and around parenthesis.
  • ISO does west const (even though its terrible).

The above code should be:

   template <ptrdiff_t... LHS , ptrdiff_t... RHS>
     constexpr bool operator==(const extents<LHS...>& lhs, const extents<RHS...>& rhs);

Action Items:

  • Fix for P0009
  • Fix for P0019

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.