ORNL / ORNL/cfd-verify

Complete Verification of Eça and Hoekstra 2014 Method

Open
#39 0 comments 0 reactions 1 assignee View on GitHub

@jrweinmeister is already working on this.

Since Aug 19, 2026.

bug
Dominant language
Python
Stars
7
Forks
1
PR merge metrics
No merged PRs in 30d

Description

The Eça and Hoekstra method was implemented in #7 and merged in #33, but it has not been fully verified and includes a test which is expected to fail. It is currently believed that the method is properly implemented and discrepancies exist because of the least squares solver, but this has not been conclusively proven.

To fully verify the method, the following should be conducted:

  • If possible, obtain original data from 2014 Eça and Hoekstra paper rather than digitally extract it.
  • Confirm least squares solver returns the true least squares solution for a manually generated problem with a known exact solution.
  • Compare results to the Marin solver written by Eça. This still may differ from the original data.
  • Compare results to additional data.
Image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.