ORNL / ORNL/ReSolve

Support unpreconditioned GMRES

Open
#467 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
84
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Summary

Add support for unpreconditioned GMRES when precond = "none".

Rationale

Unpreconditioned GMRES provides a useful baseline for evaluating new preconditioners, including improvements in iteration count and total runtime with setup costs included. It also helps with debugging by narrowing down the source of failures through preconditioned and unpreconditioned runs.

Description

A minimal implementation would be to add PreconditionerIdentity, a class derived from Preconditioner that represents $M = I$ and is therefore mathematically equivalent to applying no preconditioner. This approach would simply reuse the existing preconditioner interface and GMRES implementation with minimal changes.

Alternatively, GMRES could provide a dedicated unpreconditioned path that does not use $M$ at all, but this would require more changes.

Additional information

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the existing Preconditioner interface, GMRES implementation, and handling of precond = "none"; then inspect how current preconditioners are selected and applied. Implement support using the existing interface as described, and verify that unpreconditioned GMRES runs successfully and can provide a baseline for preconditioned runs.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.