SystemSolver still uses string to select preconditioning side
Open
Beginner friendly
Nobody has claimed this yet.
enhancement
good first issue
- Dominant language
- C++
- Stars
- 84
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Description
Summary
Left preconditioning was added in #417 and most solvers use an enum to decided which side of preconditioning to use. However, SystemSolver was left out and is still using a string to decide
Rationale
No response
Description
No response
Additional information
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the SystemSolver implementation and compare its preconditioning-side selection with the enum-based approach introduced in issue #417. Confirm the existing tests or solver entry points that cover both sides, then verify that SystemSolver no longer relies on a string and retains the expected behavior for each preconditioning side.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100