ORNL / ORNL/ReSolve

Warnings in the CUDA backend

Open
#372 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

compiler warnings cuda
Dominant language
C++
Stars
84
Forks
13
PR merge metrics
No merged PRs in 30d

Description

I noticed some warnings in the CUDA backend while testing #371. Deprecated features that may be removed in future CUDA versions.

A first set of warning pertains to csrilu02Info_t

In file included from /home/97k/ReSolve/tests/functionality/testRandGmres.cpp:27:
/home/97k/ReSolve/resolve/LinSolverDirectCuSparseILU0.hpp:65:40: warning: ‘csrilu02Info_t’ is deprecated: The type will be removed in the next major release [-Wdeprecated-declarations]
   65 |     csrilu02Info_t      info_A_{nullptr};
      |                                        ^
In file included from /usr/local/cuda/include/cusolverSp.h:53,
                 from /home/97k/ReSolve/resolve/workspace/LinAlgWorkspaceCUDA.hpp:4,
                 from /home/97k/ReSolve/resolve/workspace/LinAlgWorkspace.hpp:6,
                 from /home/97k/ReSolve/tests/functionality/testRandGmres.cpp:24:
/usr/local/cuda/include/cusparse.h:238:22: note: declared here
  238 | struct csrilu02Info* csrilu02Info_t CUSPARSE_DEPRECATED_TYPE;
      |                      ^~~~~~~~~~~~~~

Another set of warnings pertains to cuSolver calls. We have found cuDSS to be less performant that cuSolver, but we will eventually need to address this if the feature is removed. E.g.,

/home/97k/ReSolve/resolve/LinSolverDirectCuSolverRf.cpp: In member function ‘virtual int ReSolve::LinSolverDirectCuSolverRf::setup(ReSolve::matrix::Sparse*, ReSolve::matrix::Sparse*, ReSolve::matrix::Sparse*, ReSolve::index_type*, ReSolve::index_type*, ReSolve::LinSolverDirectCuSolverRf::vector_type*)’:
/home/97k/ReSolve/resolve/LinSolverDirectCuSolverRf.cpp:135:47: warning: ‘cusolverStatus_t cusolverRfSetupDevice(int, int, int*, int*, double*, int, int*, int*, double*, int, int*, int*, double*, int*, int*, cusolverRfHandle_t)’ is deprecated: please use cuDSS instead [-Wdeprecated-declarations]

Build environment:

  • pdesx system
  • CUDA 12.9
  • gcc 11.4.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with resolve/LinSolverDirectCuSparseILU0.hpp and resolve/LinSolverDirectCuSolverRf.cpp, then build the CUDA backend with the reported CUDA 12.9 environment to reproduce the warnings. Trace the deprecated csrilu02Info_t and cuSolver calls, and define completion as an agreed supported replacement or documented compatibility path with the warnings addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.