Naming scheme for vector classes
Open
@pelesh is already working on this.
Since Oct 18, 2023.
enhancement
question
- Dominant language
- C++
- Stars
- 84
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Description
It might be a good idea to decide on vector naming schemes. I think it would be important to have these schemes analog to what we settled on for matrices. Here are a few suggestions:
- Rename namespace
vectortomultivector. Then renameVectorclass toDensein analogy with matrix objects. The class will be called asmultivector::Dense, i.e. this convention would include thatusing namespace multivectoris never invoked. - Alternatively, we could keep the namespace as
vectorand rename the classMultiDense, so the invocation of the type name would bevector::MultiDense. This name is a little bit cumbersome, but it also allows us to derive single vector from multivector class trivially and then have another type namevector::SingleDense. This may provide more flexibility.
Once we decide, it is straightforward to update names of classes and files.
@kswirydo @cameronrutherford @rothpc please chime in.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.