ORNL / ORNL/GridKit

Cleanup and harmonize output streams

Open
#512 0 comments 1 reaction 1 assignee View on GitHub

@nkoukpaizan is already working on this.

Since Sep 9, 2026.

Dominant language
C++
Stars
27
Forks
11
Avg merge
3d 8h
Merged PRs (30d)
23

Description

We currently have several instances for std::cout and std::cerr throughout the code. We now have a Logger that we can use instead.

  • We can replace most std::cerr instances with Log::error() (or Log::warning() depending on the severity)
  • We can replace most std::cout with Log::misc().
  • We currently have some commented out std::cout for debugging. Assess whether they are still needed and either remove or replace with Log::misc().

We may want to consider supporting both std::cout and std::cerr by default in the logger, but I personally don't think that's necessary.

Note: in earlier profiling, Log::misc() << "some output" << std::endl; would show up as a hotspot. I recommend "\n" moving forward unless flushing is really necessary.

CC @PhilipFackler @pelesh

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.