ORNL / ORNL/GridKit

Remove examples with hard-wired input?

Open
#356 2 comments 0 reactions 2 assignees View on GitHub

@abirchfield is already working on this.

Since Apr 2, 2026.

new case question
Dominant language
C++
Stars
27
Forks
11
Avg merge
3d 8h
Merged PRs (30d)
23

Description

Question: Should we keep examples with hard-wired input i.e. 2-bus and 3-bus examples where inputs are not read from JSON input file but are hard-coded?

  • Pros: The examples are informative of GridKit model assembly functionality and may be helpful for new developers to learn how the model assembly operates.
  • Con: JSON input format is well tested and hard-wired examples are a small maintenance overhead. They may be misleading or confusing for some users who want to learn basic GridKit usage.

@nkoukpaizan

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.