Set pmech and efd in Genrou hard_coded_residual
Open
@joshua-x-7 is already working on this.
Since Oct 14, 2025.
bug
good first issue
testing
- Dominant language
- C++
- Stars
- 27
- Forks
- 11
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 23
Description
In the Genrou hard_coded_residual test, since we are not calling gen.initialize() and there are no control devices, pmech_set_ and efd_set_ are never initialized. They default to 0 in most situations I have tested, but this is not guaranteed. I've been experimenting with another way of handling those set points that led to an undefined behavior. Initializing those values to 0 where they are declared makes the test pass, but I doubt that's the behavior we want.
Also see the discussion in #266 for the case where signal nodes are used.
cc @joshua-x-7 @abirchfield @pelesh
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.