ORNL / ORNL/GridKit

InitializeCondition initType

Open
#20 0 comments 0 reactions 2 assignees View on GitHub

@abdourahmanbarry is already working on this.

Since Sep 16, 2024.

enhancement
Dominant language
C++
Stars
27
Forks
11
Avg merge
3d 8h
Merged PRs (30d)
23

Description

initializeSimulation, in Ida.cpp, calls IDACalcIC which calls for an initType variable. For tests like the GENROU example, having initType be IDA_YA_YDP_INIT generates oscillation on generation, while IDA_Y_INIT generates steady state conditions on generation.

It might be beneficial to change the logic for how the initType is determined. Simply hardcoding it to IDA_Y_INIT causes an error with the GenConstLoad test (subprocess aborted).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.