Inconsistent Use of `PetscInt`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 15
- Forks
- 9
- Avg merge
- 4h 34m
- Merged PRs (30d)
- 1
Description
Issue applies to:
- pflow
- OPFLOW
- TCOPFLOW
- SCOPFLOW
- SOPFLOW
- CMake and build system
- Spack
- Visualization
- Documentation
- Other
Summary
Currently we have inconsistent use of PetscInt and standard types (int). This results in build errors when petsc is built with 64-bit integers enabled.
Description how to reproduce the issue
- Configure and build petsc with the
--with-64-bit-indicesflag. - Try to build exago against that petsc build.
ExaGO version
develop
System and environment details
- ubuntu 22.04
- gcc 15
- CPU (x86_64)
- petsc 3.24
Additional information
No response
Possible fix or workaround
Any integer variable in exago used in calls to petsc functions (or exago functions with PetscInt parameters) should be declared as PetscInt.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the pflow, OPFLOW, TCOPFLOW, SCOPFLOW, and SOPFLOW areas for integer variables passed to PETSc functions or ExaGO functions with PetscInt parameters. Reproduce the issue with PETSc configured using --with-64-bit-indices, then rebuild ExaGO; done means the build succeeds without integer-width mismatches.
Written by the indexing model from the issue text.
Assessment
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100