OHDSI / OHDSI/WebAPI

WebAPI refactoring

Open
#533 10 comments 0 reactions 3 assignees View on GitHub

@anthonysena is already working on this.

Since Jul 14, 2019.

Dominant language
Java
Stars
151
Forks
183
Avg merge
14m
Merged PRs (30d)
2

Description

  1. Structure (domain vs type of file)
    TBD

  2. Controller-service-repository

  • Would be great to move closer to Spring terminology and use controller for a collection of REST endpoint, service for a collection of functions implementing application business logic and repository for a collection of persistance functions.
  • Use the three terms as postfixes for the appropriate files
  1. Clean-up of some services / etc to make them more atomic and granular
    E.g. there are some services having N thousand of lines of code, which not only contain too big amounts of code for a single file but also have nested classes which could be moved into separate files.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.