OHDSI / OHDSI/WebAPI

level2_concept_name condition duplicated

Open
#2,468 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
151
Forks
183
Avg merge
14m
Merged PRs (30d)
2

Description

Just reading some code and I'm pretty sure that level2_concept_name is duplicated in src/main/resources/resources/cdmresults/sql/report/condition/treemap.sql. The second one should be level1_concept_name like in src/main/resources/resources/cdmresults/sql/report/conditionera/treemap.sql

  CONCAT(
    isNull(concept_hierarchy.level4_concept_name, 'NA'), '||',
    isNull(concept_hierarchy.level3_concept_name, 'NA'), '||',
    isNull(concept_hierarchy.level2_concept_name, 'NA'), '||',
    isNull(concept_hierarchy.level2_concept_name, 'NA'), '||',       <---- should be level1_concept_name
    isNull(concept_hierarchy.concept_name, 'NA')
  ) AS concept_path,

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open src/main/resources/resources/cdmresults/sql/report/condition/treemap.sql and inspect the concept_path CONCAT expression. Compare it with src/main/resources/resources/cdmresults/sql/report/conditionera/treemap.sql, then verify that the duplicated level2_concept_name is replaced by level1_concept_name and the generated path is correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
sql
Domain
database
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.