OHDSI / OHDSI/WebAPI

WebAPI JUnit tests need documentation and update

Open
#239 3 comments 1 reaction 1 assignee View on GitHub

@leeevans is already working on this.

Since Jul 14, 2019.

enhancement system
Dominant language
Java
Stars
151
Forks
183
Avg merge
14m
Merged PRs (30d)
2

Description

I've spent some time trying to get the IT (integration tests) in WebAPI to run and I'm not sure if it's an issue with the updates to the spring boot library, but the tests are not completely functional, from what I can tell.

By default we have the pom.xml specify to skip tests:

<plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-surefire-plugin</artifactId>
        <version>2.18.1</version>
        <configuration>
          <skipTests>true</skipTests>
        </configuration>
</plugin>

So we haven't been running tests in a while.

I think we need to revisit the way tests are being coded, or maybe all that's required is documentation, but it's not clear about how tests should be executed and implemented.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.