The Korean sentence order in Authorship description is incorrect.
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 151
- Forks
- 183
- Avg merge
- 14m
- Merged PRs (30d)
- 2
Description
Expected behavior
Below picture is the sample of Authorship description in english.
created by ohdsi on 2024-02-08 8:46
In korean, the description must be as below.
ohdsi가 2024-02-08 8:46에 생성
Actual behavior
But, currently the description is very strange to korean since the sentence order is not proper.
만들어진 by ohdsi ~에 2024-02-08 8:46
Steps to reproduce behavior
You may change the language as below.
Solution
To solve this problem, I added createdEnd and modifiedEnd to the components.authorship entry in the i18n/messages_ko.json file.
I think this is the only method of choice because the order of sentences in Korean is different.
And In Atlas UI, the authorship.html must be changed to use the added createdEnd and modifiedEnd.
I already change both source WebAPI and Atlas, then test was done in my local environment.
I will commit the changes to both WebAPI and Atlas.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the components.authorship entry in i18n/messages_ko.json and the authorship.html template in Atlas UI. Compare the Korean and English authorship descriptions, then run the local environment tests or reproduction steps. Done means the Korean description uses the proper sentence order for created and modified timestamps; the issue reports that this work is already implemented locally.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html, java, json
- Domain
- frontend, internationalization
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 25/100