OHDSI / OHDSI/WebAPI

Fix CohortCharacterizationServiceTest.java tests

Open
#2,376 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
151
Forks
183
Avg merge
14m
Merged PRs (30d)
2

Description

Expected behavior
  • unit tests pass
Actual behavior
  • unit tests fail with:
Error:    CohortCharacterizationServiceTest.testExportGeneration:105->doTestExportGeneration:132->checkRequest:151 Checking dataitem org.ohdsi.webapi.cohortcharacterization.CohortCharacterizationServiceTest$ParamItem@130c39d9[analysisIds=[107],cohortIds=[2],isSummary=false,isComparative=false] expected:<1> but was:<0>
Error:    CohortCharacterizationServiceTest.testExportGenerationWithStrata:110->doTestExportGeneration:132->checkRequest:151 Checking dataitem org.ohdsi.webapi.cohortcharacterization.CohortCharacterizationServiceTest$ParamItem@747b18e5[analysisIds=[107],cohortIds=[2],isSummary=false,isComparative=false] expected:<1> but was:<0>

Steps to reproduce behavior
  • run mvn test

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with CohortCharacterizationServiceTest.java, especially testExportGeneration, testExportGenerationWithStrata, doTestExportGeneration, and checkRequest. Run mvn test and inspect why the expected data item count is 1 while the actual count is 0. Done means the failing tests pass and the full Maven test run succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.