OHDSI / OHDSI/WebAPI

Improve cohort definition deletion behavior

Open
#2,259 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
151
Forks
183
Avg merge
14m
Merged PRs (30d)
2

Description

Expected behavior

When you delete a cohort definition, if there are associated analyses that use this cohort definition, you should be notified of those references.

In addition, should be able to easily 'detach' cohort definitions from other analyses so you can delete the cohort.

Actual behavior

If you delete a cohort definition that has a foreign key (FK) to an analysis design, you are notified that you are unable to delete, but no further information is offered. You have to go through logs looking for the FK violations, and what tables are violating, and then do additional queries to look up with analyses reference the cohort definition-to-delete. Then you need to edit each analysis to remove the cohort def, and then finally delete the cohort itself.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing cohort definition deletion and the foreign-key handling for analysis designs in WebAPI. Done should include identifying analyses that reference a cohort definition, notifying the user of those references, and providing a way to detach the cohort from each analysis before deletion.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, database
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.