OHDSI / OHDSI/WebAPI

Idea : if read permissions are filtered, users will want to make some artifacts public

Open
#2,236 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
151
Forks
183
Avg merge
14m
Merged PRs (30d)
2

Description

Issue #2222 discussed the idea of making read permissions controlled more granular (see below). An implication might be that a user would like a simple way to make a given artifact publicly viewable (readable to all other users). Without some additional work to that proposed in #2222, the user would have to manually select every other user of the system to grant read access. Thus, it might be appropriate to add the ability to do so with a single check box (or other ui element) in the user interface.

The implications would be as follows:

  • there would be a need for a new system role that is granted to every user, that is not easily deleted, and that would initially be have no permissions assigned. As users select to make their artifacts public, the read permission for each artifact would be added to the TBD role and thereby make it possible for all users to see the artifact in lists such as the concept set or cohort lists.
flowchart LR
    A[design artifact] -->|edit| B(save)
    B --> |edit| C{write access}
    C -->|group| E[all users in a  group]
    C -->|user| F[single user]
    B --> |edit| D{read access}
    D -->|public| G[global read]
    D -->|group| H[all users in a  group]
    D -->|user| I[single user]

NOTE: In Atlas, this could be implemented by change the modal form presented after clicking the the lock icon present in the concept set expression view to allow the user to edit both read and write access:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue #2222 and the Atlas concept set expression view, especially the lock-icon modal mentioned here. Done would require an agreed design for making an artifact publicly readable, including how the all-users role and read access should behave.

Written by the indexing model from the issue text.

Assessment

Domain
authorization
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.