OHDSI / OHDSI/WebAPI

Move Solr files to Broadsea-Solr

Open
#2,165 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Proposal
Dominant language
Java
Stars
151
Forks
183
Avg merge
14m
Merged PRs (30d)
2

Description

Currently, we have the Solr files maintained in this repo, as a reference for users to be able to stand up Solr search for their WebAPI instance.

As there are quite a bit of configuration changes to make, along with just the Solr install itself, I am thinking it might be best to shift these files to a separate repo for more direct maintenance and easier usage. I've made a PR for the Broadsea-Solr repo (https://github.com/OHDSI/Broadsea-Solr/pull/1) to address this.

Now, I realize that not everyone can use Docker, but the solr/ folder within this proposed PR would be something even non-Docker users could grab and run with. If we agree on this idea, I can shift the parameter tokenization steps from being hardcoded in the Dockerfile to a separate shell script that Docker and non-Docker users can leverage.

So TLDR: remove Solr files from WebAPI and direct users (assuming we merge my PR) to the Broadsea-Solr repo instead.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing Solr files and the Dockerfile in this repository, then compare them with the proposed Broadsea-Solr repository PR. Done means removing the Solr files from WebAPI and directing users to Broadsea-Solr, with parameter tokenization moved to a shared shell script if that approach is adopted.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, shell
Domain
search
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.