OHDSI / OHDSI/WebAPI

EXPORT FAILED for plp/ple if some of included cohorts was removed

Open
#1,693 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
151
Forks
183
Avg merge
14m
Merged PRs (30d)
2

Description

WebAPI 2.8

Steps:
1)Create a plp/ple analysis
2)Add some cohorts to design
3)Remove one of the cohort from atlas(Request URL: WebAPI/cohortdefinition/181
Request Method: DELETE)
4)try to export Ple/PLP or download Study Package

Expected:
The cohort will remove from designs or we will see some information on the messages tab

Actual:

Request URL:WebAPI/estimation/78/export
Request Method: GET
Status Code: 500

Response:
{"payload":{"cause":null,"stackTrace":[],"message":"An exception occurred: java.lang.reflect.UndeclaredThrowableException","localizedMessage":"An exception occurred: java.lang.reflect.UndeclaredThrowableException","suppressed":[]},"headers":{"id":"c1447c41-936c-afe1-852d-258a31a9a45e","timestamp":1605780921710}}

Log:
2020-11-19 10:08:58.192 ERROR http-nio-8080-exec-1 org.ohdsi.webapi.util.GenericExceptionMapper - - java.lang.reflect.UndeclaredThrowableException at com.sun.proxy.$Proxy253.exportAnalysis(Unknown Source) at org.ohdsi.webapi.estimation.EstimationController.exportAnalysis(EstimationController.java:154) at org.ohdsi.webapi.estimation.EstimationController$$FastClassBySpringCGLIB$$71f94499.invoke(<generated>) at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204) at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:667) at org.ohdsi.webapi.estimation.EstimationController$$EnhancerBySpringCGLIB$$6230433b.exportAnalysis(<generated>) at sun.reflect.GeneratedMethodAccessor935.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with EstimationController.java around line 154 and reproduce the export through /estimation/78/export after deleting a referenced cohort via /cohortdefinition/181. Trace how the missing cohort is handled during PLP/PLE export or Study Package download. Done means the export no longer returns HTTP 500 and the design removes the cohort or reports it in the messages tab.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.