OHDSI / OHDSI/WebAPI

Source daimon priority issue

Open
#1,681 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
151
Forks
183
Avg merge
14m
Merged PRs (30d)
2

Description

  1. Priority source daimons (priority=1) can be deleted.
  2. When recreated, its priority set to 0.

Steps to reproduce:

  1. Login as admin, open "Configuration" page, open source with priority daimons. (Check DB table "source_daimons": this source's daimons priority = 1).
  2. Uncheck "Vocabulary" and (or) "Result" daimon, save. In DB table "source_daimons": unchecked daimons priority = -1.
  3. Open same daimon, create "Vocabulary" and (or) "Result" daimon. In DB table "source_daimons": created daimons priority = 0.

As a result, we have no "Vocabulary" and "Result" daimon with priority = 1, despite the fact that radiobuttons on the "Configuration" page are checked. To restore priority we need to switch "Change source priorities in:" to "Whole application" and change source's "Vocabulary Version" and "Record Counts (RC / DRC)".

Possible solution: do not allow deletion of daimons with priority=1.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Configuration page flow and the source_daimons table described in the reproduction steps, tracing how disabling and recreating Vocabulary or Result daimons changes priority. Reproduce the sequence as an admin and verify that priority-1 daimons cannot be deleted or that their priority is preserved when recreated.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.