OHDSI / OHDSI/WebAPI

Migrate Spring Batch sequences from sequence tables

Open
#1,074 3 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

enhancement system
Dominant language
Java
Stars
151
Forks
183
Avg merge
14m
Merged PRs (30d)
2

Description

In prior WebAPI updates related to sequences, we avoided changing the existing Spring Batch sequences out of concern of breaking changes. However, we've seen locking issues related to the spring sequence tables. It appears that Spring Batch does support using sequences to manage the _SEQ sequences:
https://docs.spring.io/spring-batch/3.0.x/reference/html/metaDataSchema.html#metaDataIdentity

It is not clear how the framework works currently to determine to use either sequences (where you use next value for in Sql Server) vs. doing a select-and-update approach on the table-based sequences (perhaps the Spring Batch framework does an object-type check?)

In any case, it appears that by default Spring Batch supports sequences, so this Issue is to migrate the following tables to sequences:

  • BATCH_STEP_EXECUTION_SEQ
  • BATCH_JOB_EXECUTION_SEQ
  • BATCH_JOB_SEQ

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.