Resolve global Ruff findings after phenotype workflow sprint
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 12
- Forks
- 7
- Avg merge
- 2m
- Merged PRs (30d)
- 12
Description
Current state
ruff check acp_agent core mcp_server scripts tests reports 13 findings. Targeted Ruff checks for the phenotype workflow and companion R-client compatibility cleanup pass; this issue tracks the remaining repository-wide debt.
StudyAgent findings (inspect before removal)
acp_agent/study_agent_acp/agent.py contains earlier definitions that Ruff reports as redefined by later implementations:
__init__at lines 76 and 511list_toolsat lines 504 and 1421call_toolat lines 507 and 1434- unused local
nameat line 1336
The earlier methods appear to be obsolete stubs or shadowed implementations. Remove or reconcile them only after checking the class layout and ACP behavior; do not mechanically refactor the orchestration class. Run focused ACP routing, server, and phenotype tests afterward.
Other low-risk findings
- unused local
nameinacp_agent/study_agent_acp/phenotype_recommendation_utils.py - unused
allowed_setincore/study_agent_core/tools.py - unused imports in
tests/test_acp_cohort_methods_route.pyandtests/test_mcp_phenotype_summary.py - mid-file imports in
tests/test_cohort_methods_spec_validation.py
Suggested completion checks
- Run focused tests for every affected behavior, particularly ACP server/routing and phenotype recommendation tests when editing
StudyAgent. - Run
ruff check acp_agent core mcp_server scripts tests. - Run
git diff --check. - Run the normal Python gate,
uv run --extra dev doit test_all; separately report any unrelated existing failures rather than masking them.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running ruff check acp_agent core mcp_server scripts tests and inspect the duplicate definitions in acp_agent/study_agent_acp/agent.py before changing them. Review the other listed files and run the focused ACP, phenotype, and affected tests. Done means the findings are resolved, the focused tests pass, git diff --check is clean, and uv run --extra dev doit test_all has been run with unrelated failures reported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa, tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100