OHDSI / OHDSI/StudyAgent

ACP mcp_client.py has allot of duplicate code - simplify

Open
#25 0 comments 0 reactions 1 assignee View on GitHub

@rkboyce is already working on this.

Since Mar 28, 2026.

enhancement
Dominant language
Python
Stars
12
Forks
7
Avg merge
2m
Merged PRs (30d)
12

Description

Coding agents are very good at coding but this can lead to allot of duplicate code. This has happened to acp_agent/study_agent_acp/mcp_client.py where allot code is duplicated under the definitions for StdioMCPClient and HttpMCPClient. This taksk is to generalize what is called in both definitions to simplify the code. Probably a good idea run a check for other such opportunities.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.