OHDSI / OHDSI/PatientGenerator

Refactor timeline: extract pure helper utilities from onRender

Open
#3 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
5
Forks
1
Avg merge
7h 2m
Merged PRs (30d)
4

Description

Context
onRender currently owns setup, interaction handlers, and DOM synchronization.

Recommendation
Extract pure utility helpers (e.g., selector builders, date formatting helpers, type/color maps) from onRender to improve readability and maintainability.

Acceptance criteria

  • Helper functions are side-effect free where possible
  • Main render function becomes shorter and easier to scan
  • No functional regression

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating onRender and reviewing its setup, interaction handlers, and DOM synchronization responsibilities. Identify pure selector, date-formatting, and type/color-map helpers that can be separated without changing behavior. Done means the render function is shorter and easier to scan, helpers are side-effect free where possible, and there is no functional regression.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.