OHDSI / OHDSI/FeatureExtraction
computeStandardizedDifference does not handle temporal covariate data
Nobody has claimed this yet.
- #228 by @gowthamrao — closed without merging
- Dominant language
- R
- Stars
- 74
- Forks
- 63
- PR merge metrics
- No merged PRs in 30d
Description
The covariates is covariateData object from temporalAnalysis settings has timeId. computeStandardizedDifference appears to not know that. it only joins by covariateId, instead of covariateId, timeId. This causes a cartesian product.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating computeStandardizedDifference and reviewing how temporalAnalysis supplies covariateData with timeId. Reproduce the temporal covariate case and inspect the join keys to confirm the cartesian product. Done means temporal rows are matched by both covariateId and timeId, with the existing behavior preserved for non-temporal data.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100