OHDSI / OHDSI/FeatureExtraction

Throw an error if two covariate builders generate overlapping covariate IDs

Open Beginner friendly
#168 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue
Dominant language
R
Stars
74
Forks
63
PR merge metrics
No merged PRs in 30d

Description

When calling getDbCovariateData() with a list of covariate settings, FeatureExtraction iterates over the builders, and appends the covariate data. It would be good if an error was thrown if two covariate builders create overlapping covariate IDs.

For speed it may be advisable to check overlap based on covariateRef rather than covariates itself.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in R/GetCovariates.R at lines 124-165, where getDbCovariateData() iterates over builders and appends covariate data. Trace how covariate IDs or covariateRef values are available before appending. Done means overlapping IDs from two builders cause an error rather than being silently combined.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.