OHDSI / OHDSI/FeatureExtraction

Incorrect documentation of getDbCovariateData?

Open
#145 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
R
Stars
74
Forks
63
PR merge metrics
No merged PRs in 30d

Description

Hi!

I'm trying to work out a bug, and wonder if the cohort_end_date should not also be required in the documentation for the getDbCovariateData-function?

"This function uses the data in the CDM to construct a large set of covariates for the provided cohort. The cohort is assumed to be in an existing table with these fields: 'subject_id', 'cohort_definition_id', 'cohort_start_date'. Optionally, an extra field can be added containing the unique identifier that will be used as rowID in the output."

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the getDbCovariateData documentation and implementation, then verify whether cohort_end_date is required. Done means correcting the documented required fields if the function requires it and checking the resulting wording.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.