OHDSI / OHDSI/FeatureExtraction

M

Open
#125 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
74
Forks
63
PR merge metrics
No merged PRs in 30d

Description

Double checking:
https://github.com/OHDSI/FeatureExtraction/blob/da48fda9f27cb3c8fa34cc3f91ee741071dc51bb/inst/sql/sql_server/DemographicsAge.sql#L190

Should this not be N? is it now not taking missing as a zero in the mean? It will not happen since we require at least Y of birth but anyway..

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read inst/sql/sql_server/DemographicsAge.sql around line 190 and inspect the surrounding age-feature logic. Verify whether the expression should use N rather than M and how missing birth years affect the mean; done means the SQL behavior matches the intended missing-value handling.

Written by the indexing model from the issue text.

Assessment

Tech stack
r, sql
Domain
databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.