OHDSI / OHDSI/DatabaseConnector

question on interactive behavior for redshift drivers

Open
#246 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
57
Forks
93
Avg merge
10d 12h
Merged PRs (30d)
1

Description

Why is there an interactive behavior setup for Redshift?
Perhaps there could be a parameter for the downloadJdbcDrivers function to automatically overwrite or skip if files are found?

for (db in dbms) {
    if (db == "redshift") {
      oldFiles <- list.files(pathToDriver, "Redshift")
      if (length(oldFiles) > 0) {
        message(sprintf("Prior JAR files have already been detected: '%s'. Do you want to delete them?", paste(oldFiles, collapse = "', '")))
        if (interactive() && utils::menu(c("Yes", "No")) == 1) {
          unlink(file.path(pathToDriver, oldFiles))
        }
      }
    }

Code Here

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in R/Drivers.R around lines 104-113 and inspect how downloadJdbcDrivers handles existing Redshift JAR files. Clarify the parameter's overwrite and skip behavior, then update the function so non-interactive callers can select that behavior and verify the existing-driver path still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
databases
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.