OHDSI / OHDSI/DatabaseConnector
Download drivers `method` argument
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 57
- Forks
- 93
- Avg merge
- 10d 12h
- Merged PRs (30d)
- 1
Description
The function for downloading drivers downloadJdbcDrivers has an argument method which is then passed to utils::download.file per the documentation here:
Looking at the documentation for utils::download.file, the method argument will assume a default value of auto but it can be overridden using options(download.file.method = "auto").
So I'd propose we remove the method argument since it prevents users from controlling the behavior of utils::download.file using options and instead we can just note this in the description of the function or link to the utils documentaiton.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with downloadJdbcDrivers in R/Drivers.R at the linked implementation and compare its method handling with the utils::download.file documentation. Done means removing the method argument and documenting that download.file behavior can be controlled through options(download.file.method = "auto").
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100