OHDSI / OHDSI/CommonDataModel

errors in inst/csv/OMOP_CDMv6.0_Field_Level.csv

Open
#722 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
1.1k
Forks
508
Avg merge
1h 30m
Merged PRs (30d)
3

Description

The csv file that contains the field-level specs for the OMOP CDM v6.0 seems to have some errors in it.

For example:

(1) In the drug_exposure table, the field stop_reason is present, even though it is explained in the user guidance that this field "will be retired in v6.0."

(2) In several tables, the requirements on date/datetimes seems to be reversed. The explanation at https://ohdsi.github.io/CommonDataModel/cdm60.html#Changes_in_v60 is that "DATETIME fields were made mandatory and date fields were made optional." This is true in the spec for some tables (e.g., visit_occurrence), but the opposite is specified for condition_occurrence and drug_exposure.

It looks to me like some of the specs were updated appropriately in this file for v5.4 -> v6.0, but for certain tables, the field-level specs from v5.4 were simply repeated in the file for v6.0 when they should have been changed.

Examples above are not intended to be exhaustive, they are simply a few observations.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review inst/csv/OMOP_CDMv6.0_Field_Level.csv alongside the v6.0 changes described at the linked Common Data Model page. Check the drug_exposure stop_reason entry and date/datetime requirements in condition_occurrence and drug_exposure, then compare the remaining v6.0 field specifications with the documented changes. Done means all identified v5.4 carryovers are corrected in the CSV.

Written by the indexing model from the issue text.

Assessment

Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.