OHDSI / OHDSI/CommonDataModel

Move era table scripts to GitHub, make them SQL-dialect specific?

Open
#551 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement
Dominant language
HTML
Stars
1.1k
Forks
508
Avg merge
1h 30m
Merged PRs (30d)
3

Description

People should always run the era scripts when ETL-ing (right?), but the scripts are currently here in OHDSISql.

Maybe it would be better to provide them in the dialect-specific GitHub folders instead, so for example for Postrges put the script here?

(As discussed with @aostropolets)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Era_Tables section of sqlScripts.html and compare it with the dialect-specific folders under inst/ddl/5.4, including postgresql. Determine whether the era scripts are required during ETL and whether each SQL dialect needs its own copy; done means the agreed location and dialect coverage are documented and the affected scripts or references are updated.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgresql, sql
Domain
databases
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.