OHDSI / OHDSI/CommonDataModel

Fact_relationship changes

Open
#230 22 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Proposal
Dominant language
HTML
Stars
1.1k
Forks
508
Avg merge
1h 30m
Merged PRs (30d)
3

Description

We decided to introduce concept_id's for each field in OMOP cdm. e.g. we will be assigning a concept_id for person.person_id, visit_occurrence.visit_occurrence_id etc. To be released in future version of vocabulary. e.g. cost.cost_event_field_concept_id needs concept_id for each identify of the field.

Proposal 1: This proposal is to change FACT_RELATIONSHIP table's domain_concept_id to field_concept_id, where field_concept_id is the identity of the field in omop cdm.

Field Required Type Description
domain_concept_id_1 Yes integer The concept representing the domain of fact one, from which the corresponding table can be inferred.
field_concept_id_1 Yes integer A foreign key identifier to a concept in the concept table representing the identity of the field of fact one.
fact_id_1 Yes integer The unique identifier in the table corresponding to the domain of fact one.
domain_concept_id_2 Yes integer The concept representing the domain of fact two, from which the corresponding table can be inferred.
field_concept_id_2 Yes integer A foreign key identifier to a concept in the concept table representing the identity of the field of fact two.
fact_id_2 Yes integer The unique identifier in the table corresponding to the domain of fact two.
relationship_concept_id Yes integer A foreign key to a Standard Concept ID of relationship in the Standardized Vocabularies.

Proposal 1: will help overcome domain ambiguity such as does the domain_id = 'Visit' represent visit_occurrence or visit_detail.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the current FACT_RELATIONSHIP table definition and the proposed field_concept_id changes described here, then read the discussion to determine whether Proposal 1 was accepted. Confirm the target CDM and vocabulary release before changing any schema or DDL; done means the decision and resulting table definition are agreed and consistently documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
sql
Domain
databases
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.