OData / OData/odataorg.github.io
ODataUrlValidator.ValidateProperties null reference exception on dynamic properties
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 73
- Forks
- 106
- PR merge metrics
- No merged PRs in 30d
Description
ODL returns a NullReferenceException when validating URLs with dynamic properties for deprecation.
Sample repro uri: graph.microsoft.com/v1.0/drives('<key>')/items('<key>')/<dynamic>
Stack trace:
at Microsoft.OData.UriParser.Validation.ODataUrlValidator.ValidateProperties(IEdmType edmType, ODataUrlValidationContext context) in D:\a\1\s\src\Microsoft.OData.Core\UrlValidation\ValidationEngine\ODataUrlValidator.cs:line 444
at Microsoft.OData.UriParser.Validation.ODataUrlValidator.ValidateSelectExpandClause(IEdmType segmentType, SelectExpandClause selectExpand, ODataUrlValidationContext validationContext) in D:\a\1\s\src\Microsoft.OData.Core\UrlValidation\ValidationEngine\ODataUrlValidator.cs:line 249
at Microsoft.OData.UriParser.Validation.ODataUrlValidator.ValidateUrl(ODataUri odataUri, IEnumerable`1& validationMessages) in D:\a\1\s\src\Microsoft.OData.Core\UrlValidation\ValidationEngine\ODataUrlValidator.cs:line 66
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/Microsoft.OData.Core/UrlValidation/ValidationEngine/ODataUrlValidator.cs, especially ValidateProperties at the reported line and its call from ValidateSelectExpandClause. Reproduce the sample dynamic-property URL and verify that URL validation no longer raises a NullReferenceException.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100