OData / OData/AspNetCoreOData

GetModel() instead of request.GetModel() in EnableQuery

Open
#736 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C#
Stars
505
Forks
186
PR merge metrics
No merged PRs in 30d

Description

Assemblies affected
8.0.11

Describe the bug
GetModel from EnableQuery not working
I think in this line
https://github.com/OData/AspNetCoreOData/blob/4676237520ebed2b73cd1f1531a1a175c1213207/src/Microsoft.AspNetCore.OData/Query/EnableQueryAttribute.cs#L86
should be GetModel() instead of request.GetModel()

Expected behavior
Using GetModel from EnableQuery

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/Microsoft.AspNetCore.OData/Query/EnableQueryAttribute.cs at the line linked in the issue. Compare the current request.GetModel() call with GetModel() from EnableQuery and verify which model is expected when EnableQuery is used. Confirm the correction against the reported expected behavior for assembly version 8.0.11.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
api, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.