OData / OData/AspNetCoreOData

OrderByBinder is inheritable, but no used according to own api

Open
#502 0 comments 0 reactions 1 assignee View on GitHub

@xuzhg is already working on this.

Since Mar 1, 2022.

enhancement help wanted
Dominant language
C#
Stars
505
Forks
186
PR merge metrics
No merged PRs in 30d

Description

It is possible to register IOrderByBinder and use OrderByBinder as baseclass.
However, the OrderByClause it is called with does not contain any .ThenBy values even if they are in the query, instead it is called multiple times.
I do like the comment in code: "// TODO: need to refactor it later."
The generated Expression tree is correct enough, but there is no way to customize it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.