OData / OData/AspNetCoreOData

FilterRestrictions and SortRestrictions not applied if using EntityType<>

Open
#501 6 comments 0 reactions 1 assignee View on GitHub

@xuzhg is already working on this.

Since Feb 24, 2022.

Dominant language
C#
Stars
505
Forks
186
PR merge metrics
No merged PRs in 30d

Description

Classes:

   private abstract class TestBase
   {
      public                               int Id      { get; set; }
      public                               int CanBase { get; set; }
      [NotFilterable] [NotSortable] public int NotBase { get; set; }
   }

   private class Test : TestBase
   {
      public int Can { get; set; }
      [NotFilterable] [NotSortable] public int Not { get; set; }
   }

   private class Test2 : TestBase
   {
      public                               int Can { get; set; }
      [NotFilterable] [NotSortable] public int Not { get; set; }
   }

Works:

     var builder = new ODataConventionModelBuilder();
     builder.EntitySet<Test>("test");
     builder.EntitySet<Test2>("test2");
     return builder.GetEdmModel();

Doesnt work (NotBase is not marked as notfilterable, nor notsortable):

     var builder = new ODataConventionModelBuilder();
     builder.EntityType<TestBase>();
     builder.EntitySet<Test>("test");
     builder.EntitySet<Test2>("test2");
     return builder.GetEdmModel();

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.