OData / OData/AspNetCoreOData

rewrite GroupByShaperExpression to support ef core group by sql evaluation

Open
#229 2 comments 2 reactions 1 assignee View on GitHub

@xuzhg is already working on this.

Since Jul 13, 2021.

bug EFCore
Dominant language
C#
Stars
505
Forks
186
PR merge metrics
No merged PRs in 30d

Description

Hi. I've noticed for a long time that this issue hasn't been solved since release of ef core 2. Maybe now its finally a time to fix it ? If you don't know what I'm talking about just run the ODataRoutingSample in this repo, set the ef core provider to sql server and send this request http://localhost:64771/Products?$apply=groupby((Color),aggregate($count as Count)) and you will be greet with following exception:

InvalidOperationException: Processing of the LINQ expression 'GroupByShaperExpression:
KeySelector: new GroupByWrapper{ GroupByContainer = new LastInChain{
Name = N'Color',
Value = (object)p.Color
}
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.