OAI / OAI/OpenAPI-Specification
v3.3: Allow `in: query` and `in: querystring` and/or multiple `in: querystring`s together?
Nobody has claimed this yet.
- Dominant language
- Markdown
- Stars
- 31.2k
- Forks
- 9.2k
- Avg merge
- 6h 37m
- Merged PRs (30d)
- 27
Description
IMPORTANT NOTE: @karenetheridge has convinced me that in: querystring and in: query really cannot be combined, so this original post here is not really accurate anymore. However,in: querystring overrides might work. I'll try to clean this all up or maybe re-file it when I get a chance.
Revised proposal starts at https://github.com/OAI/OpenAPI-Specification/issues/5366#issuecomment-4672179041
NOTE: This is primarily relevant if #5320 is accepted, as it dramatically widens the scope of potential interactions by allowing global parameters. If #5320 is rejected, this can probably just be closed wontfix.
To keep things simple with in: querystring, we added two restrictions, which apply across both the Operation and Path Item level:
- There can only be one
in: querystringparameter - If there is an
in: querystringparameter, there cannot be anyin: queryparameters
We missed a querystring option elsewhere
However, we did overlook that the type: apiKey, in: query Security Scheme effectively adds an in: query parameter which we did not explicitly forbid (and I do not consider the current wording to implicitly forbid it, as "parameter" was intended to mean Parameter Object).
Technically, there isn't a problem here: You can just tack the API key parameter onto the query string on either end, and as long as you remove it first when parsing, there's no ambiguity.
None of the potential problems are new
Ambiguous groups of object-property-name-defined query paramters already occur within: query, explode: trueAs noted (and warned against) in Appendix E, with very particular use ofallowReserved: truewith minimal percent-encoding (and noform-urlencoded-specific escaping), plus use of aform-urlencodedparser, it is possible to misinterpret a+as an escaped space when it was serialized as a literal+. This requires the user to make an effort to work around the typical behavior, and we already warn that it will cause a bug if the user does so.
We can make the ambiguity better, and the escaping/encoding issue is not worse
We could also improve the situation with in: querystring by mandating its position relative to other query parameters (whether in: querystring or in: query). For example:
when multiplein: querystringparamters are present, the global ones MUST be serialized first (directly after the?), in the order they appear in the global array, then the path item ones, then the operation oneswhenin: querystringparamters are present, they MUST all appear before anyin: queryor security scheme parameters (or MUST all appear after, it doesn't matter as long as it is consistent)
This would substantially reduce the number of possible ways to parse the resulting URL when it is recieved.
We could also make corresponding SHOULD recommendations regarding in: query (and other) parameter ordering, we just can't make it a MUST because of compatibility. In fact, without this SHOULD, the behavior is already inherently implementation-defined.
(paging @karenetheridge for implementor feedback)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the revised proposal in the issue comment linked from the body, then review the current in: querystring restrictions and the type: apiKey, in: query interaction described here. Done means the discussion has one clear, agreed normative proposal, or the issue is re-filed or closed if its scope is rejected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- openapi
- Domain
- api, documentation
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100