OADA / OADA/server

Fix rev-graph-update

Open
#157 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15
Forks
43
PR merge metrics
No merged PRs in 30d

Description

What occurred:

  1. target-helper had an error update and rejected a job.
  2. jobs deleted the job from the pending queue
  3. a rev-graph update came in late
  4. then the final job fail status came in

As a result a job entry only had a _rev key. We just want to make sure that final change is not lost entirely by the job watcher.

[
  {
    "resource_id": "resources/29xL9znRy5BfCNxdoOfo3pkxJ4N",
    "path": "",
    "body": {
      "2A1k6RS0YOuzlD4wtDiNTUZe3E8": null,
      "_meta": {
        "modifiedBy": "users/433",
        "modified": 1654267058.506,
        "_rev": 4087
      },
      "_rev": 4087
    },
    "type": "delete"
  }
]
[
  {
    "resource_id": "resources/29xL9znRy5BfCNxdoOfo3pkxJ4N",
    "path": "",
    "body": {
      "2A1k6RS0YOuzlD4wtDiNTUZe3E8": {
        "_rev": 8
      },
      "_meta": {
        "modifiedBy": "system/rev_graph_update",
        "modified": 1654267058.59,
        "_rev": 4088
      },
      "_rev": 4088
    },
    "type": "merge"
  },
  {
    "resource_id": "resources/2A1k6RS0YOuzlD4wtDiNTUZe3E8",
    "path": "/2A1k6RS0YOuzlD4wtDiNTUZe3E8",
    "body": {
      "status": "failure",
      "result": {
        "name": "TimeoutError"
      },
      "_meta": {
        "modifiedBy": "users/433",
        "modified": 1654267053.628,
        "_rev": 8
      },
      "_rev": 8
    },
    "type": "merge"
  }
]

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the job watcher and rev-graph update handling, then trace the event sequence shown in the report. Done means the late rev-graph update and final failure status are not lost, and the job entry does not end up containing only a _rev key.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend, distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.