NuggoDEV / NuggoDEV/CountersPlus

ParentedToBaseGameHUD canvas setting not working as it should

Open
#93 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
152
Forks
35
PR merge metrics
No merged PRs in 30d

Description

When setting ParentedToBaseGameHUD to true, the canvas position are not being respected. With this setting on, the x axis position changes are mirrored, y axis changes does not take effect at all, and z axis changes (with match base game z turned off) works, but it does not move the base game combo and multiplyer.

Attaching a couple of screenshots.
First one is in counterplus settings (with ParentedToBaseGameHUD turned on)
Second one is in game with those settings
Third one is in game with ParentedToBaseGameHUD turned off

Also attaching the example config file I used.

Sorry if it's a known issue, did not see anything about it in any of the changelogs and open/closed issues.
Note - I have not tried any of the rotation settings, but it's likely the base game counters will not be affected by those changes either.

example config
in game
in game (parent off)

Config used for testing -

{
  "Enabled": true,
  "HideCombo": false,
  "HideMultiplier": false,
  "ComboOffset": 0.3,
  "MultiplierOffset": 0.5,
  "ItalicText": true,
  "AprilFoolsTomfoolery": true,
  "HUDConfig": {
    "MainCanvasSettings": {
      "Name": "Main",
      "ParentedToBaseGameHUD": true,
      "IgnoreNoTextAndHUDOption": false,
      "Size": 12.0,
      "PositionScale": 12.0,
      "Pos_X": 1.0,
      "Pos_Y": 0.4999995,
      "Pos_Z": 5.0,
      "MatchBaseGameHUDDepth": false,
      "Rot_X": 0.0,
      "Rot_Y": 0.0,
      "Rot_Z": 0.0,
      "AttachHUDToCamera": false,
      "AttachedCamera": "Main Camera",
      "IgnoreShockwaveEffect": true,
      "CurveRadius": 95.0,
      "DistanceModifier": 0.5
    },
    "OtherCanvasSettings": []
  },
  "MissedConfig": {
    "Enabled": true,
    "Position": "BelowCombo",
    "Distance": 0,
    "CountBadCuts": true,
    "CanvasID": -1
  },
  "NoteConfig": {
    "Enabled": false,
    "Position": "BelowMultiplier",
    "Distance": 1,
    "ShowPercentage": false,
    "DecimalPrecision": 2,
    "CanvasID": -1
  },
  "ProgressConfig": {
    "Enabled": true,
    "Position": "BelowEnergy",
    "Distance": -1,
    "Mode": "Original",
    "ProgressTimeLeft": true,
    "IncludeRing": true,
    "CanvasID": -1
  },
  "ScoreConfig": {
    "Enabled": true,
    "Position": "BelowMultiplier",
    "Distance": 0,
    "Mode": "Original",
    "DecimalPrecision": 2,
    "DisplayRank": true,
    "CustomRankColors": true,
    "SSColor": "#DBB4FF",
    "SColor": "#FFFFFF",
    "AColor": "#20B120",
    "BColor": "#C2B520",
    "CColor": "#C3690E",
    "DColor": "#FF0000",
    "EColor": "#FF0000",
    "CanvasID": -1
  },
  "PBConfig": {
    "Enabled": false,
    "Position": "BelowMultiplier",
    "Distance": 1,
    "Mode": "Absolute",
    "BetterColor": "#FF0000",
    "DefaultColor": "#FFA500",
    "DecimalPrecision": 2,
    "TextSize": 2,
    "UnderScore": true,
    "HideFirstScore": false,
    "CanvasID": -1
  },
  "SpeedConfig": {
    "Enabled": false,
    "Position": "BelowMultiplier",
    "Distance": 2,
    "DecimalPrecision": 2,
    "Mode": "Average",
    "CanvasID": -1
  },
  "CutConfig": {
    "Enabled": true,
    "Position": "AboveCombo",
    "Distance": 1,
    "SeparateSaberCounts": true,
    "SeparateCutValues": false,
    "AveragePrecision": 1,
    "CanvasID": -1
  },
  "SpinometerConfig": {
    "Enabled": false,
    "Position": "AboveMultiplier",
    "Distance": 0,
    "Mode": "Highest",
    "CanvasID": -1
  },
  "NotesLeftConfig": {
    "Enabled": false,
    "Position": "AboveHighway",
    "Distance": -1,
    "LabelAboveCount": false,
    "CanvasID": -1
  },
  "FailsConfig": {
    "Enabled": false,
    "Position": "AboveCombo",
    "Distance": 0,
    "ShowRestartsInstead": false,
    "CanvasID": -1
  },
  "CustomCounters": {}
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the HUD canvas handling for MainCanvasSettings.ParentedToBaseGameHUD and reproduce the behavior with the supplied example config. Trace how Pos_X, Pos_Y, Pos_Z, and base-game HUD elements are applied; done means parented canvas positioning works on all reported axes and the base-game combo and multiplier move as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.