NuggoDEV / NuggoDEV/CountersPlus

Account for Modifier score changes

Open
#144 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
152
Forks
35
PR merge metrics
No merged PRs in 30d

Description

I've been using this mod for a while now, and it used to show PB percentage, while accounting for modifiers. Now, modifiers seem to be ignored, and the mod shows the percentage compared to the base score.

For example, a perfect score with no modifiers will show as 100%, regardless of modifiers used after that. Previously, the PB would show the accuracy you'd need with those modifiers, so that same perfect PB would show as 92.5% if you turned on Faster Song. If your PB is above that 100% base score, this part of the mod is mostly useless.

I loved this feature, as it made it really easy to track my performance in-game in relation to my PB. If it's possible, please bring this feature back.

Adding this in for better context, I'm on game version 1.37.2, and mod version 2.3.7

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name any files, tests, or entry points. Start by reproducing the PB percentage behavior in Beat Saber 1.37.2 with and without modifiers, then trace the counter's score and modifier handling. Done means the displayed percentage reflects the accuracy required with active modifiers, including the Faster Song example.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.