NucleoidMC / NucleoidMC/server-wrapper

GitHub workflow runs are sorted by update date

Open
#4 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
3
Forks
6
Avg merge
8d 14h
Merged PRs (30d)
1

Description

If two workflow runs targeting different commits are triggered in quick succession, and the workflow run based on the old commit finishes last, then the artifact chosen will be based on the old commit.

The sorting logic should be improved to handle this case:

https://github.com/NucleoidMC/server-wrapper/blob/7bf3579bab605b5caa461aac4ee4a6ba49b89b47/src/source/github.rs#L37-L38

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/source/github.rs at lines 37-38 and inspect how workflow runs are sorted before artifact selection. Reproduce the quick-successive-run case described in the issue and verify that artifact selection is no longer determined by an older commit finishing last.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, rust
Domain
ci-cd
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.