NotionX / NotionX/react-notion-x
Feature request: Twitter emojis by default
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.4k
- Forks
- 645
- PR merge metrics
- No merged PRs in 30d
Description
If the goal is to replicate Notion look as closely as possible, shouldn't we use the same emojis?
Notion uses the Twitter emojis, avaliable here: https://github.com/jdecked/twemoji.
We could use jsDelivr as a CDN to deliver them, see for instance: https://cdn.jsdelivr.net/gh/jdecked/twemoji@latest/assets/svg/1f60a.svg.
Something like <img src="https://cdn.jsdelivr.net/gh/jdecked/twemoji@latest/assets/svg/1f60a.svg" alt="😊" width="20" height="20" /> works but probably we would need to create a react component and maybe use dangerouslySetInnerHTML(?) I really don't know, I'm not familiar with react nor the repo logic, but this does not seem like a very difficult thing to implement.
It would be an awesome feature to have because I personally very much dislike the default Windows 11 emojis.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Start by locating how the React renderer currently outputs emojis, then review the Twemoji and jsDelivr references in the issue. Done means emojis render with Twitter artwork by default without breaking their accessible text or sizing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100