NotionX / NotionX/react-notion-x
PDF file URLs won't be signed
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.4k
- Forks
- 645
- PR merge metrics
- No merged PRs in 30d
Description
Description
At this time, NotionAPI.addSignedUrls only signs URLs which contains secure.notion-static.com string (#332).
Notion is currently serving PDF (may be also other type files, I don't test) files from "https://prod-files-secure.s3.us-west-2.amazonaws.com/<uuid1>/<uuid2>/<name>.pdf" style urls, which won't be signed by NotionAPI.addSignedUrls.
Notion Test Page ID
1387d259b2558024b095eb5c50425400
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate NotionAPI.addSignedUrls and trace how it recognizes secure.notion-static.com URLs. Reproduce the issue with the provided Notion Test Page ID and verify that prod-files-secure.s3.us-west-2.amazonaws.com PDF URLs are signed without breaking existing URL handling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100